Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect efficiencies default in XML parser #252

Open
pbauman opened this issue Jun 26, 2018 · 1 comment
Open

Respect efficiencies default in XML parser #252

pbauman opened this issue Jun 26, 2018 · 1 comment

Comments

@pbauman
Copy link
Member

pbauman commented Jun 26, 2018

We default to 1 and that seems to be the case in GRI3.0 xml, but may not always be the case. We should query the default and use that to set the default value in the efficiencies in three body reactions.
@pbauman
Copy link
Member Author

pbauman commented Jun 26, 2018

See #176 for comments too. Will probably need to address that before we can tackle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbauman