Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Testing Data into Classes #242

Open
pbauman opened this issue May 11, 2017 · 0 comments
Open

Consolidate Testing Data into Classes #242

pbauman opened this issue May 11, 2017 · 0 comments

Comments

@pbauman
Copy link
Member

pbauman commented May 11, 2017

While adding testing to #240, it became clear we are starting to get some redundancy in testing data, e.g. coefficients for NASA polynomials, across testing classes. We should consolidate all this data into a class that can be subclassed so all the "gold" data is in one place. I was thinking maybe just ChemicalSpeciesData or some such (which can help with unit testing of chemical species parsing...) and then any test that needs that data can just subclass it and grab it as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant