Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around for Qt's QSvgRenderer weakness. #80

Open
be1 opened this issue Nov 15, 2020 · 4 comments
Open

Work around for Qt's QSvgRenderer weakness. #80

be1 opened this issue Nov 15, 2020 · 4 comments

Comments

@be1
Copy link

be1 commented Nov 15, 2020

Hello,
Qt's QSvgRenderer does not render correctly SVG files generated by abcm2ps.
See: https://bugreports.qt.io/browse/QTBUG-88494
But maybe you would like to cherry-pick this workaround: 630a235 from https://github.com/be1/qabc.git (in the lib branch)...

@moinejf
Copy link
Collaborator

moinejf commented Nov 15, 2020

Hi,
This does not work: you lose the 'currentColor'.

@be1
Copy link
Author

be1 commented Nov 15, 2020

Hello,
Even if that patch is a bad hack (sure), currentColor isn't anyway "black" ?

@moinejf
Copy link
Collaborator

moinejf commented Nov 15, 2020

No, it is not. Try that:

X:1
L:1/4
K:C
%%voicecolor red
CDEF|GABc|

@be1
Copy link
Author

be1 commented Nov 16, 2020

Thanks for the hint.
If I could see in the code where currentColor is changed, I could modify the patch.
But it seems currentColor is never changed, for now: colors change are written directly as color or bgcolor attributes, as I can see. e.g:

svg.c:		fprintf(fout, "color:#%06x;", gcur.rgb)

But I understand this could change in future versions, and that, anyway, currentColor is a handy feature that should not be broken (by my patch). So I won't cry ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants