Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define visible for the Stage class #211

Open
adroitwhiz opened this issue Jul 16, 2024 · 0 comments
Open

Define visible for the Stage class #211

adroitwhiz opened this issue Jul 16, 2024 · 0 comments

Comments

@adroitwhiz
Copy link
Collaborator

There are a couple places in the codebase where we have an object that is a Sprite or a Stage, and we need to check if it's visible. Because visible is only defined for Sprite, this is awkward and requires us to do "visible" in target ? target.visible : true.

Instead, we could define a visible getter for Stage that always returns true, and just omit the setter. If JS allows it, we may be able to just define the getter on SpriteBase and only define the setter on Sprite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant