-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pinToMonitor is still mentioned in documentation even though it is no longer supported in code. #460
Comments
Good find. Looking at the old code I think I can add it back, but if you tell it to pin to a monitor that does not exist it will move the browser off the screen and it will be lost. It depended on a function to get monitor count that does not exist in .net core 2. |
Looking at the code, a workaround may be just make it a user defined value rather than a function call. Something along the lines of forcing users to set a canopy.screenmonitorCount value of non 1 before calling pintoMonitor? Otherwise it's not a huge deal since I believe most users are running their UI tests headless making this a minor inconvenience. |
ah yes I could check that. |
Any update on this? |
That is the old code. I dont know if System.Windows.Forms.SystemInformation.MonitorCount is in .net Core 3.0 or System.Windows.Forms.Screen.AllScreens For now I will remove from documentation |
I don't know if this was an intentional reversion or not, but pinToMonitor is no longer defined in the source code. It does still show up on the website documentation however.
The text was updated successfully, but these errors were encountered: