Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity reporter shows skipped tests as passed instead of ignored #350

Closed
galatrash opened this issue Mar 7, 2017 · 6 comments
Closed

Comments

@galatrash
Copy link

Please change the TeamCity reporter to report skipped tests as being ignored and not passed.

Here is the scenario I use: I begin with a test that installs a full web site and if it fails I set:
canopy.configuration.skipAllTestsOnFailure <- true
so that all subsequent tests are ignored and bypassed. But TeamCity shows something like this:
Tests failed: 1, passed: 99
which is misleading. The right thing to show is something like this:
Tests failed: 1, ignored: 99

@lefthandedgoat
Copy link
Owner

Do you have this part backwards?

 But TeamCity shows something like this:
Tests failed: 1, passed: 99
which is misleading. The right thing to show is something like this:
Tests failed: 1, ignored: 99

I think now it would show failed: 1, ignored: 99 but you want it to say passed I think?

I can do this, but skip in canopy is the same as the Ignore attribute in nUnit etc, in that it does not run the test. Team city does not have a skip, they have Pass, fail, and ignore and in my opinion ignore is the match of the given choices.

I can try to make something work for you, but I need to figure something out that doesn't break backward compat.

@galatrash
Copy link
Author

I need TeamCity to show ignored.

Maybe you can add a flag (e.g., reporter.showSkippedAsIgnored) which by default has backward compatibility and it can be changed to show ignored.

@lefthandedgoat
Copy link
Owner

Ok, showing ignored is the correct thing. If it is not it is a bug, so I do not need to focus on backwards compat.

You can see here that it is writing ignored to the console, but if it is not working I will figure it out.

https://github.com/lefthandedgoat/canopy/blob/master/src/canopy/reporters.fs#L180

Can you tell me what version of TeamCity you are using? I will get it installed and repro and fix.

Thanks!

@galatrash
Copy link
Author

galatrash commented Mar 8, 2017

I'm using the latest: TeamCity Enterprise 10.0.4 (build 42538)

BTW, you can see a sample of this case here (use "login as guest"):
https://build.dnnsoftware.com/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=716818#_focus=899

@lefthandedgoat
Copy link
Owner

This is fixed in the latest version of canopy that you can download here: https://www.nuget.org/packages/canopy/1.2.0

@galatrash
Copy link
Author

It is working properly now. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants