reporters: print all details of exception, not only the stack #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's fine if canopy wants to highlight the error by printing the exception message first, the URL, and then the details. But the details of it shouldn't be just the stacktrace because: - It doesn't contain the type of the exception. - It doesn't contain details about InnerExceptions. I found this the hard way: receiving a "One or more errors occurred" error, and not knowing what was going on for a while. Later I realized that the exception was AggregateException (which normally wraps exceptions that happen in async/parallel code), and that it had the best explanation in the InnerException of it.
|
You can find a new package here: https://www.nuget.org/packages/canopy/1.0.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fine if canopy wants to highlight the error by printing
the exception message first, the URL, and then the details.
But the details of it shouldn't be just the stacktrace because:
I found this the hard way: receiving a "One or more errors
occurred" error, and not knowing what was going on for a while.
Later I realized that the exception was AggregateException
(which normally wraps exceptions that happen in async/parallel
code), and that it had the best explanation in the InnerException
of it.