Reporter fail exception fix #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for the fail function in the runner. In the case of a misbehaving website that timed out the screenshot function might also timeout as the webdriver may be busy trying to retrieve the html page. Fix for the fail function ensures that the entire test run is not broken because of a single test/page fail. Also made the screenshot save location configurable.
|
Thanks, I love pull requests! Would you like a new nuget build for this? |
lefthandedgoat
added a commit
that referenced
this pull request
May 17, 2014
Reporter fail exception fix
|
I just made another :-) That was the last one I had to merge back from my larger web test project. I would love a new nuget package after that one. Thanks a lot. On 17 May 2014 21:29, lefthandedgoat [email protected] wrote:
|
|
This is now in canopy 0.9.10 https://www.nuget.org/packages/canopy/0.9.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix for the runner.fail method that can fail with a WebDriverTimeoutException.
Tested with a misbehaving website that sometimes aborted requests (crappy firewall). In the case of a misbehaving/stuck page the test would fail (after various timeouts) but the webdriver would still be stuck and the subsequent screenshot request would fail. Tested with the firefox webdriver.
Also added support for configuration of the screenshot path.