Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme code simplification #8900

Merged

Conversation

indirectlylit
Copy link
Contributor

@indirectlylit indirectlylit commented Dec 12, 2021

Summary

Follow-up from #8805 with more to come after.

In the theme code I originally tried defining constants in the Python theme_hook module which are simply references to strings used elsewhere in the code. These constants turn out to be more trouble than they're worth, mainly because they add a layer of indirection when someone is trying to figure out how all the theme logic fits together. They fail the grep test.

Additional changes:

  • remove unnecessary checks
  • simplify default theme

References

Will link to this PR from other relevant repos and PRs. See back-references below description.

Reviewer guidance

Seem reasonable?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@indirectlylit
Copy link
Contributor Author

@rtibbles this is ready for review.

I'm working on a follow-up PR which adds theme spec validation to this based on #8640 and #8878 and removes validation from Python

@indirectlylit
Copy link
Contributor Author

These changes should be fairly low-risk, but there is still a non-zero risk of regression. If we're down to the wire on 0.15, recommend combining with #8902 and putting them both in a patch of 0.15

@indirectlylit indirectlylit changed the base branch from release-v0.15.x to theme-updates December 14, 2021 03:25
@indirectlylit
Copy link
Contributor Author

indirectlylit commented Dec 14, 2021

merging into theme-updates feature branch

ref: #8918

@indirectlylit indirectlylit merged commit 52a6f15 into learningequality:theme-updates Dec 14, 2021
@indirectlylit indirectlylit modified the milestones: 0.15.0, 0.15.1 Dec 14, 2021
@indirectlylit indirectlylit deleted the theme-changes branch December 14, 2021 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant