Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up from #8805 with more to come after.
In the theme code I originally tried defining constants in the Python
theme_hook
module which are simply references to strings used elsewhere in the code. These constants turn out to be more trouble than they're worth, mainly because they add a layer of indirection when someone is trying to figure out how all the theme logic fits together. They fail the grep test.Additional changes:
References
Will link to this PR from other relevant repos and PRs. See back-references below description.
Reviewer guidance
Seem reasonable?
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)