Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite scalar coercion to stop depending on deprecated methods #451

Open
kaqqao opened this issue Apr 10, 2023 · 0 comments
Open

Rewrite scalar coercion to stop depending on deprecated methods #451

kaqqao opened this issue Apr 10, 2023 · 0 comments

Comments

@kaqqao
Copy link
Member

kaqqao commented Apr 10, 2023

The entire scalar coercion implementation has to change, because:

a) graphql-java deprecated the methods SPQR is currently using (e.g. parseValue(Object)) and the new signatures cause problems in ValueMapper, which also operates outside of query execution and thus has no access to GraphQLContext

b) SPQR can't reliably tell a Java type is mapped as scalar when deserializing the inputs, so flimsy workarounds like this are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant