Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed localization after update #1283

Closed
lutz opened this issue Feb 28, 2019 · 5 comments
Closed

Failed localization after update #1283

lutz opened this issue Feb 28, 2019 · 5 comments
Labels
translation i18n and l10n

Comments

@lutz
Copy link

lutz commented Feb 28, 2019

Operating system

  • Windows

Application

  • Desktop

Errors

No errors displayed in the console

After changing from version 1.0.127 to version 1.0.135, the main bar is no longer displayed in the set language.

grafik

@tessus tessus added the translation i18n and l10n label Mar 2, 2019
@tessus
Copy link
Collaborator

tessus commented Mar 2, 2019

Due to a bug in Electron (see electron/electron#11106), the top level menu items had to prefixed with a &. Therefore the translations are missing and have to be adjusted.

@laurent22: I updated the German translation in db1dab9, before 1.0.135 was released. Why isn't this reflected in the build? Or is there another bug with localization and electron?

@tessus
Copy link
Collaborator

tessus commented Mar 2, 2019

/cc @laurent22 - I mistyped your username in the last comment (forget the 22) and so I'm not sure, if you were notified.

@laurent22
Copy link
Owner

Yes that PR wasn't well thought out since it affects such a visible place of the application. Next time I'll ask to batch process the po files and add a reasonable default to all the translations. @tessus, I didn't build the translations recently as I just wanted to get the last release bugs fixed. It will be in the next release.

@772b
Copy link

772b commented Mar 4, 2019

Yes that PR wasn't well thought out since it affects such a visible place of the application. Next time I'll ask to batch process the po files and add a reasonable default to all the translations. @tessus, I didn't build the translations recently as I just wanted to get the last release bugs fixed. It will be in the next release.

thank you for the v1.0.137 fixed #1282 , it's OK now,thank very much. ^_^

@tessus
Copy link
Collaborator

tessus commented May 8, 2019

This has been fixed already. Closing.

For future reference: there a certain situations where a translation has to be re-translated. This is not a bug, but requires someone to change/improve the .po file.

@tessus tessus closed this as completed May 8, 2019
@lock lock bot locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
translation i18n and l10n
Projects
None yet
Development

No branches or pull requests

4 participants