Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_rowaddr and _rowid not exposed for merge? #3251

Open
oceanusxiv opened this issue Dec 16, 2024 · 2 comments
Open

_rowaddr and _rowid not exposed for merge? #3251

oceanusxiv opened this issue Dec 16, 2024 · 2 comments

Comments

@oceanusxiv
Copy link

I have a simple use case where I want to pull down all rows of a column from a lance dataset, do some custom processing locally, and add the resulting rows (same length) directly back up to the same lance dataset. (The local processing involves some windowing operation which is why the straight SQL update syntax won't work).

It looks like the most supported way to do this is via the merge syntax, where I can feed in a precomputed data frame and join on index columns. This is great and all, but I couldn't figure out how to do this without manually generating some custom index column that basically ends up being the same as a _rowaddr anyways, except actually manifested in the dataset instead of being a meta column.

It seems strange to me that such a simple operation as adding a column with the same row count as the existing dataset is so complicated, but at least if _rowaddr is exposed to merge operations than it saves the inconvenience of generating a redundant row idx column manually.

@chenkovsky
Copy link
Contributor

chenkovsky commented Dec 16, 2024

is this what you want #3254 ? I'm faced with similar problem. @oceanusxiv

@oceanusxiv
Copy link
Author

@chenkovsky oh wow that was quick, yes, that's what I want, didn't realize row address was already read anyways, so it's just an interface limitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants