Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ray write lance error #3229

Open
Jay-ju opened this issue Dec 11, 2024 · 3 comments
Open

ray write lance error #3229

Jay-ju opened this issue Dec 11, 2024 · 3 comments
Assignees

Comments

@Jay-ju
Copy link
Contributor

Jay-ju commented Dec 11, 2024

ref: ray-project/ray#49211

@westonpace
Copy link
Contributor

It looks like release 2.38 refactored how ray.data.Datasink works and this broke our integration.

In version 2.37 and below each call to write was allowed to return some output:

A user-defined output. Can be anything, and the returned value is passed to on_write_complete().

However, in version 2.38, the signature for write changed to return None.

We were relying on this feature because, in each call to write, we create a "fragment" and return the fragment metadata (a small JSON string). In on_write_complete we would take these fragments and commit them as a single transaction, completing the write.

I suppose we will need to figure out some other way to store temporary state in version 2.38. Maybe we can we store it on the datasink itself? My hunch is that this will not work because the write calls will run on a different worker than the call to on_write_complete.

@westonpace
Copy link
Contributor

(sorry, didn't realize you had created a PR when I wrote that comment)

Let me try out your PRs today

@Jay-ju
Copy link
Contributor Author

Jay-ju commented Dec 15, 2024

yes, i have fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants