Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CommitConflict error #3223

Open
wjones127 opened this issue Dec 9, 2024 · 0 comments
Open

Improve CommitConflict error #3223

wjones127 opened this issue Dec 9, 2024 · 0 comments

Comments

@wjones127
Copy link
Contributor

CommitConflict error doesn't seem to be well understood. The problem is likely that with the transactions it is way too long. We should show a short Display of the transactions instead of a full Debug representation. If we shorten them, we can make the transactions in the message fields / attributes of the error, so they are still accessible if we need them to debug.

Example:

LanceDBClientError: Internal Server
Error: 500, error: {"code":500, "error": "LanceDB: database: N/A: lance error: Commit conflict for version 27: There was a concurrent commit that conflicts with t
his one and it cannot be automatically resolved. Please rerun the operation off the latest version of the table. \n Transaction: Transaction { read_version: 26, uuid: \"6269f1a3-3298-47f4-ad01-ef12
2eb07490\", operation: Delete { updated_fragments: [Fragment { id: 0, files: [DataFile { path: \"eb3579fa-Oaee-4ae6-b646-d08e0811fb27, lancel", fields: [0, 1, 2,
version: 0,
file_minor_version: 2 }1, deletion_file: Some(DeletionFile & read_version: 26, id: 13500629393622735842, file_type: Array,
Taun deeted rows: Some (12) 1), 0w 3d neta: None; phystcatr
ws: Some (26) }1,
deleted_fragment_ids: [1, predicate: \"path = 'docs/axolotl_readme.md'|" }, tag: None A\n Conflicting Transaction: Some(Transaction { read_version: 26, uuid: \"9de412bd-ef9e-496d-
a961-d05ddd4cb8f0\", operation: Delete { updated_fragments: [Fragment { id: 0, files: [DataFile { path: \"eb3579fa-Oaee-4a6-b646-d080811fb27. lancel", fields: [0, 1, 2, 31, column_indices: [1, f le_major_version: 0,
file_minor_version: 2 }l, deletion_file: Some(DeletionFile { read_version: 26,
id: 14627442727684223444,
file_type: Array, num_deleted_rows: Some (1) }), row_id_meta: None, phy
sical rows: Some(26) }], deleted fragment ids: [l, predicate: \"path = 'docs/test-again.md'|" }, tag: None }), /src/lance/rust/lance/src/io/commit.rs:111:23"}
@wjones127 wjones127 added this to the Better error handling milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant