Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MirrorSource.reduce result for companionPath #20207

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Use MirrorSource.reduce result for companionPath #20207

merged 1 commit into from
Apr 17, 2024

Conversation

EugeneFlesselle
Copy link
Contributor

@EugeneFlesselle EugeneFlesselle commented Apr 16, 2024 •
edited
Loading

Fixes #20187

bishabosha
bishabosha approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to delete all that code :)

@bishabosha bishabosha merged commit 2176fe4 into scala:main Apr 17, 2024
19 checks passed
@bishabosha bishabosha deleted the companionPath branch April 17, 2024 07:59
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 6, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 6, 2024
@WojciechMazur
Backport "Use MirrorSource.reduce result for companionPath" to LTS (
aaa2925 
#21074)

Backports #20207 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Crash when summoning mirror for match type aliased in separate compilation
3 participants
@EugeneFlesselle @bishabosha @Kordyjan