Normalize types before collecting parts determining implicit scope #20077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneFlesselle
force-pushed
the
issues/i20071
branch
2 times, most recently
from
b28dfa2 to
1a8e9b0
Compare
This is necessary to ensure the implicit scope is consistent when involving match types, since they may or may not have been reduced before implicit search. We can for example get different results when loading from tasty than when in the same run. Fixes scala#20071
EugeneFlesselle
force-pushed
the
issues/i20071
branch
from
1a8e9b0 to
90c3fbd
Compare
EugeneFlesselle
changed the title
odersky
added a commit
that referenced
this pull request
Apr 10, 2024
Match types are already not flagged as `Deferred` when unpickled. This caused varying results for `ImplicitRunInfo#isAnchor`, by not reaching the `isMatchAlias` condition when created from the Namer. Ensures both #20071 and #20136 each have the same result, when compiled with a classpath dependency as when merged into a single file. Fixes #20136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to ensure the implicit scope is consistent when involving match types, since they may or may not have been reduced before implicit search.
We can for example get different results when loading from tasty than when in the same run.
Fixes #20071