Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary lits to syntax summaries #19551

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

som-snytt
Copy link
Contributor

@som-snytt
Copy link
Contributor Author

Sorry I forgot how to turn off CI over here.

@odersky
Copy link
Contributor

odersky commented Jan 28, 2024

One question: The tooling people said they want to be notifed of any changes to syntax before the syntax is rolled in. Did that happen? @tgodzik @gabro are you aware that this change has landed?

@tgodzik
Copy link
Contributor

tgodzik commented Jan 28, 2024

One question: The tooling people said they want to be notifed of any changes to syntax before the syntax is rolled in. Did that happen? @tgodzik @gabro are you aware that this change has landed?

Hmm... I don't think it did happen. We will need to take a look into it.

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@odersky
Copy link
Contributor

odersky commented Feb 1, 2024

@tgodzik @gabro Are you OK with merging this now, and you'll look into the tooling separately? Or should we hold?

@tgodzik
Copy link
Contributor

tgodzik commented Feb 1, 2024

@tgodzik @gabro Are you OK with merging this now, and you'll look into the tooling separately? Or should we hold?

I will not be able to take a look at it soon, so I would opt to hold off for a bit. I will try to find time on the weekend to take a look at it, but I can't promise anything.

@bishabosha
Copy link
Member

@tgodzik heads up it was also already merged in scala 2.13

@tgodzik
Copy link
Contributor

tgodzik commented Feb 1, 2024

Och, that ship has sailed then 😨 I will try to get some time to work on it.

@odersky
Copy link
Contributor

odersky commented Feb 15, 2024

It will land in 3.5.

@odersky odersky added this to the 3.5.0 milestone Feb 15, 2024
@odersky odersky assigned Kordyjan and unassigned odersky Feb 15, 2024
@tgodzik
Copy link
Contributor

tgodzik commented Feb 15, 2024

We added support in the latest version of Scalameta 3.9.0 scalameta/scalameta#3543

@Kordyjan Kordyjan merged commit 89dec7a into scala:main May 10, 2024
19 checks passed
@Kordyjan Kordyjan removed this from the 3.5.0 milestone May 10, 2024
@som-snytt som-snytt deleted the followup/sip-42 branch May 10, 2024 13:22
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants