Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix algorithm to prevent recursive givens #19411

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jan 10, 2024

Fixes #19404
Fixes #19407
Fixes #19417

@odersky odersky requested a review from dwijnand January 10, 2024 16:30
@odersky odersky added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jan 10, 2024
@odersky odersky added this to the 3.4.0 milestone Jan 10, 2024
@odersky odersky merged commit 84e9a9c into scala:main Jan 11, 2024
19 checks passed
@odersky odersky deleted the fix-given-loop-avoidance branch January 11, 2024 22:14
Kordyjan added a commit that referenced this pull request Jan 18, 2024
@WojciechMazur WojciechMazur removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment