Make fatal warnings not fail compilation early & aggregate warns #19245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymon-rd
force-pushed
the
move-error-warn-b3
branch
from
7b3b400 to
69927a4
Compare
szymon-rd
force-pushed
the
fatal-warnings-no-early-exit
branch
from
cbe9041 to
ee10082
Compare
szymon-rd
force-pushed
the
move-error-warn-b3
branch
from
69927a4 to
6d759fb
Compare
szymon-rd
force-pushed
the
fatal-warnings-no-early-exit
branch
from
ee10082 to
06d518d
Compare
szymon-rd
force-pushed
the
move-error-warn-b3
branch
from
6d759fb to
78adb39
Compare
szymon-rd
force-pushed
the
fatal-warnings-no-early-exit
branch
from
06d518d to
daf1718
Compare
szymon-rd
force-pushed
the
move-error-warn-b3
branch
from
78adb39 to
2994d53
Compare
szymon-rd
force-pushed
the
fatal-warnings-no-early-exit
branch
2 times, most recently
from
f8bbc39 to
2c46f0a
Compare
szymon-rd
force-pushed
the
move-error-warn-b3
branch
from
fb8e104 to
f21b0f3
Compare
szymon-rd
force-pushed
the
fatal-warnings-no-early-exit
branch
from
2c46f0a to
9ad6c72
Compare
szymon-rd
force-pushed
the
move-error-warn-b3
branch
8 times, most recently
from
039744e to
bfe0c70
Compare
szymon-rd
force-pushed
the
fatal-warnings-no-early-exit
branch
from
9ad6c72 to
68f4dbc
Compare
|
There was some problem with moving these tests to warn when I tried it before, but I will look a bit into that now to make sure. |
szymon-rd
force-pushed
the
fatal-warnings-no-early-exit
branch
from
0f48680 to
f0b2216
Compare
|
I moved most of them to warn |
| @@ -214,6 +209,10 @@ abstract class Reporter extends interfaces.ReporterResult { | |||
| def incomplete(dia: Diagnostic)(using Context): Unit = | |||
| incompleteHandler(dia, ctx) | |||
|
|
|||
| def finalizeReporting()(using Context) = | |||
| if (hasWarnings && ctx.settings.XfatalWarnings.value) | |||
| report(new Error("No warnings can be incurred under -Werror.", NoSourcePosition)) | |||
There was a problem hiding this comment.
Suggested change
| report(new Error("No warnings can be incurred under -Werror.", NoSourcePosition)) | |
| report(new Error("No warnings can be incurred under -Werror (or -Xfatal-warnings)", NoSourcePosition)) |
| @@ -216,7 +216,6 @@ class CompilationTests { | |||
| @Test def checkInitGlobal: Unit = { | |||
| implicit val testGroup: TestGroup = TestGroup("checkInitGlobal") | |||
| val options = defaultOptions.and("-Ysafe-init-global", "-Xfatal-warnings") | |||
There was a problem hiding this comment.
We should inline options into compileFilesInDir("tests/init-global/pos", options,
szymon-rd
force-pushed
the
fatal-warnings-no-early-exit
branch
from
6251697 to
e410ad4
Compare
nicolasstucki
approved these changes
Jan 30, 2024
szymon-rd
force-pushed
the
fatal-warnings-no-early-exit
branch
from
e410ad4 to
ded027e
Compare
|
This uncovered a bug in To workaround this issue do package object H:
inline def inlined =
- G.valBinaryAPI2 +
+ // G.valBinaryAPI2 + // FIXME should error (now fails -Ycheck)
G.valBinaryAPI3package J:
inline def inlined =
- I.valBinaryAPI2 +
+ // I.valBinaryAPI2 + // FIXME should error (now fails -Ycheck)
I.valBinaryAPI3and update the checkfile. |
szymon-rd
force-pushed
the
fatal-warnings-no-early-exit
branch
from
ded027e to
35b0509
Compare
nicolasstucki
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final PR. Adds functionality that changes the behaviour of fatal-warnings - fixes #18634
PR 5/5 (merge consecutively, per Nicolas' suggestion
Split up version of #18829