Get generic signature of fields entered after erasure from their accessor #19207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneFlesselle
changed the title
EugeneFlesselle
changed the title
sjrd
requested changes
Dec 8, 2023
Comment on lines
6
to
8
| val tpe = classOf[Foo].getDeclaredField("generic").getGenericType() | ||
| val tpe2 = classOf[Foo].getDeclaredMethod("generic").getGenericReturnType() | ||
| assert(tpe == tpe2) |
There was a problem hiding this comment.
This test will still pass if both the field and getter have broken signatures. We should also actually test the structure of tpe.
|
LGTM. Would you mind squashing all the commits in a single one? The individual commits here don't bring any value for the future user of |
|
@EugeneFlesselle: as you are rebasing, you can add @entangled90 and @AnotherMedo as co-authors. |
Co-authored-by: Carlo Sana <[email protected]> Co-authored-by: Matt Bovel <[email protected]>
EugeneFlesselle
force-pushed
the
mb/17069
branch
from
cfa242e to
dad90f4
Compare
sjrd
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #17069
@mbovel