Store source file in TASTY attributes #18948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
add-tasty-source-file-attribute
branch
2 times, most recently
from
979699d to
a7e774a
Compare
nicolasstucki
added
release-notes
5 tasks
nicolasstucki
force-pushed
the
add-tasty-source-file-attribute
branch
6 times, most recently
from
34629c2 to
028219c
Compare
nicolasstucki
force-pushed
the
add-tasty-source-file-attribute
branch
5 times, most recently
from
6a8eaff to
5268c6f
Compare
This was referenced Nov 27, 2023
nicolasstucki
added a commit
that referenced
this pull request
Nov 27, 2023
We generalize the internal encoding of `Attributes` to be a list of tags. Then we add add helper methods to have simpler ways to interact with this abstraction using booleans. This implies that the pickling/unpickling can be agnostic of the semantics of each tag. Therefore reducing the number of places that need to be updated when we add a new tag. Useful for #19074, #19033, and #18948.
nicolasstucki
added a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 27, 2023
We generalize the internal encoding of `Attributes` to be a list of tags. Then we add add helper methods to have simpler ways to interact with this abstraction using booleans. This implies that the pickling/unpickling can be agnostic of the semantics of each tag. Therefore reducing the number of places that need to be updated when we add a new tag. Useful for scala#19074, scala#19033, and scala#18948.
nicolasstucki
force-pushed
the
add-tasty-source-file-attribute
branch
3 times, most recently
from
27881d3 to
8f71739
Compare
bishabosha
added a commit
that referenced
this pull request
Nov 27, 2023
We add a `Utf8` encoding to the grammar. This should not to be confused with the `UTF8` name tag. This mistake was made in the `Comment` format. We also add corresponding `writeUtf8` and `readUtf8` methods to the `TastyBuffer`. This is also useful for #18948
nicolasstucki
force-pushed
the
add-tasty-source-file-attribute
branch
from
9e01840 to
50a8ca6
Compare
bishabosha
reviewed
Nov 28, 2023
| ``` | ||
|
|
||
| Standard Section: "Attributes" Attribute* | ||
| ```none | ||
| Attribute = SCALA2STANDARDLIBRARYattr | ||
| EXPLICITNULLSattr | ||
| SOURCEFILEattr Utf8 |
There was a problem hiding this comment.
should this be raw utf8 or a nametable reference?
nicolasstucki
force-pushed
the
add-tasty-source-file-attribute
branch
from
30ad31e to
adf7e3f
Compare
nicolasstucki
commented
Nov 28, 2023
nicolasstucki
force-pushed
the
add-tasty-source-file-attribute
branch
8 times, most recently
from
cad4d30 to
b52d156
Compare
nicolasstucki
force-pushed
the
add-tasty-source-file-attribute
branch
from
b52d156 to
791c6fd
Compare
bishabosha
reviewed
Dec 1, 2023
| else if isStringAttrTag(tag) then | ||
| val utf8Ref = readNameRef() | ||
| val value = nameAtRef(utf8Ref).toString | ||
| stringTagValue += tag -> value |
There was a problem hiding this comment.
perhaps we should still validate the tags - there's a (hopefully unlikely) possibility of someone stuffing the attribute section with duplicates/invalid tags in the correct range
There was a problem hiding this comment.
Invalid tags are checked with isStringAttrTag.
There was a problem hiding this comment.
Maybe I should add to the spec the fact that attribute tags cannot be repeated. I could also specify that they must be in order to make it reproducible.
This introduces the first non-boolean attribute to the TASTY format. We Split the tags into a set of boolean tags and string tags to handle This new kind of attribute. We keep some tags as unknown to allow for additional kinds of tags in the future.
Also refactor accesses to the tasty attributes to get them directly from the compilation unit info instead of the unpickler.
The only missing step is in the TODO added in this commit.
nicolasstucki
force-pushed
the
add-tasty-source-file-attribute
branch
from
0631d67 to
e942cd0
Compare
bishabosha
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add source file to TASTy attributes. This is a first step towards removing the
@SourceFileannotation.Release notes
Tools that read TASTy need to know that the source file must be unpickled from TASTy attributes.