Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated equals method for univerval equality of chars #18770

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Use dedicated equals method for univerval equality of chars #18770

merged 1 commit into from
Oct 27, 2023

Conversation

WojciechMazur
Copy link
Contributor

Uses BoxesRunTime.equalsNumChar instead of BoxesRunTime.equalsNumObject for boxed Char universal equality checks. This method was private in Scala 2.11, but is available since 2.12 allowing us to better optimize universal equality checks made with Char

Change was reflected in both JVM and JS backend (also the test sources)

@WojciechMazur
Use BoxesRunTime.equalsNumChar instead of `BoxesRunTime.equalsNumOb…
733b8bb 
…ject` for boxed Char universal equality checks
@WojciechMazur WojciechMazur requested a review from sjrd October 27, 2023 10:33
@sjrd sjrd enabled auto-merge October 27, 2023 11:08
@sjrd sjrd merged commit 835bdb4 into scala:main Oct 27, 2023
16 checks passed
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@WojciechMazur @sjrd @Kordyjan