Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Named args completions with default values #18633

Merged
merged 1 commit into from
Oct 6, 2023
Merged

bugfix: Named args completions with default values #18633

merged 1 commit into from
Oct 6, 2023

Conversation

jkciesluk
Copy link
Contributor

connected to scalameta/metals#5657

filipwiech
filipwiech approved these changes Oct 5, 2023
View reviewed changes
Copy link

@filipwiech filipwiech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@jkciesluk jkciesluk requested a review from tgodzik October 6, 2023 09:12
tgodzik
tgodzik approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik added backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools labels Oct 6, 2023
@tgodzik tgodzik merged commit 32222ad into scala:main Oct 6, 2023
18 checks passed
@Kordyjan Kordyjan removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 10, 2023
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 19, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "bugfix: Named args completions with default values" to LTS (#…
01441ae 
…20641)

Backports #18633 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur mentioned this pull request Jun 20, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "bugfix: Named args completions with default values" to LTS (#…
a5a38f0 
…20694)

Backports #18633 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@filipwiech filipwiech filipwiech approved these changes

Assignees
No one assigned
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jkciesluk @filipwiech @tgodzik @Kordyjan