A more robust scheme for resetting denotations after Recheck #18534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aim is to have an efficient test whether a phase or denot transformer should be run.
The new scheme works also for arbitrary denotation changes in PreRecheck. Furthermore, recheck denot transformers are not run after Recheck has ended. This means that effectivly only symbols touched by the Rechecker are transformed and reset again afterwards.
|
This is part of a larger capture checker refactoring. Since it affects Rechecker it should be of interest also for the refinement types work. |
No backward mapping is necessary anymore. # Conflicts: # compiler/src/dotty/tools/dotc/cc/CheckCaptures.scala
dwijnand
reviewed
Sep 18, 2023
odersky
commented
Sep 18, 2023
Need to copy the denotation, since denotations come with next pointers which would get scrambled otherwise. The bug was observed when compiling stdlib under new capture checking implementation. # Conflicts: # compiler/src/dotty/tools/dotc/transform/Recheck.scala
Linyxus
approved these changes
Sep 21, 2023
| @@ -158,16 +151,21 @@ abstract class Recheck extends Phase, SymTransformer: | |||
| // One failing test is pos/i583a.scala | |||
|
|
|||
| /** Change any `ResetPrivate` flags back to `Private` */ | |||
There was a problem hiding this comment.
the documentation seems outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new scheme works also for arbitrary denotation changes in PreRecheck.
Furthermore, recheck denot transformers are not run after Recheck has ended. This
means that effectively only symbols touched by the Rechecker are transformed and
reset again afterwards.