Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive in WUnused for renamed path-dependent imports #18468

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Fix false positive in WUnused for renamed path-dependent imports #18468

merged 5 commits into from
Sep 4, 2023

Conversation

szymon-rd
Copy link
Contributor

Fix #18366

KacperFKorban
KacperFKorban reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@KacperFKorban KacperFKorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks ok. Added one nitpick.
Also, please squash your commits before merging.

compiler/src/dotty/tools/dotc/transform/CheckUnused.scala Outdated Show resolved Hide resolved
KacperFKorban
KacperFKorban approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@KacperFKorban KacperFKorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kordyjan Kordyjan enabled auto-merge September 4, 2023 10:47
@Kordyjan Kordyjan merged commit 34df5f6 into scala:main Sep 4, 2023
@szymon-rd szymon-rd mentioned this pull request Sep 4, 2023
Closed
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 19, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "Fix false positive in WUnused for renamed path-dependent im…
089ecec 
…ports" to LTS (#20608)

Backports #18468 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur mentioned this pull request Jun 20, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "Fix false positive in WUnused for renamed path-dependent im…
77b782e 
…ports" to LTS (#20668)

Backports #18468 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KacperFKorban KacperFKorban KacperFKorban approved these changes

@Kordyjan Kordyjan Awaiting requested review from Kordyjan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

False warning about unused import for local/relative import with Scala 3.3
3 participants
@szymon-rd @KacperFKorban @Kordyjan