Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: suggest correct arg name completions for lambda expressions #18379

Merged
merged 1 commit into from
Aug 10, 2023
Merged

bugfix: suggest correct arg name completions for lambda expressions #18379

merged 1 commit into from
Aug 10, 2023

Conversation

kasiaMarek
Copy link
Contributor

backport from metals: scalameta/metals#5533
CC: @tgodzik

@tgodzik tgodzik added backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools labels Aug 10, 2023
tgodzik
tgodzik approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Btw. I added a new label area:presentation-compiler for PR and issues related to the presentation compiler module, hope nobody minds

@kasiaMarek
Copy link
Contributor Author

Btw. I added a new label area:presentation-compiler for PR and issues related to the presentation compiler module, hope nobody minds

I don't have the power to set labels.

@tgodzik
Copy link
Contributor

tgodzik commented Aug 10, 2023

Btw. I added a new label area:presentation-compiler for PR and issues related to the presentation compiler module, hope nobody minds

I don't have the power to set labels.

I just wrote if someone from the compiler team was curious what happened 😅

@tgodzik tgodzik merged commit 17a9c0c into scala:main Aug 10, 2023
@Kordyjan Kordyjan removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 10, 2023
@Kordyjan Kordyjan mentioned this pull request Dec 1, 2023
Merged
Kordyjan added a commit that referenced this pull request Dec 8, 2023
@Kordyjan
Backport "bugfix: suggest correct arg name completions for lambda exp…
9802289 
…ressions" to LTS (#19159)

Backports #18379 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@kasiaMarek @tgodzik @Kordyjan