Properly refine type of inlined unapply pattern #18292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-17525
branch
3 times, most recently
from
f9d286a to
4aed8ec
Compare
smarter
approved these changes
Aug 2, 2023
tests/pos/i17525.scala
Outdated
| object Extract { | ||
| transparent inline def unapply(value: String): Option[Tuple] = Some((1, "two")) | ||
| } | ||
| def fail(): Unit = "" match { case Extract(a, b) => } |
There was a problem hiding this comment.
can you make the test do stuff in the case based on the transparent type?
nicolasstucki
force-pushed
the
fix-17525
branch
from
4aed8ec to
9bfa854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17525