Set missing expansion span for copied inlined node #18229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tetchki
added a commit
to Tetchki/dotty
that referenced
this pull request
Jul 17, 2023
Refactoring of inlined nodes to simplify the work on scala#17055. This work is based on scala#18229.
Tetchki
added a commit
to Tetchki/dotty
that referenced
this pull request
Jul 17, 2023
Refactoring of inlined nodes to simplify the work on scala#17055. This work is based on scala#18229.
Tetchki
added a commit
to Tetchki/dotty
that referenced
this pull request
Jul 17, 2023
Refactoring of inlined nodes to simplify the work on scala#17055. This work is based on scala#18229.
julienrf
reviewed
Jul 26, 2023
Tetchki
force-pushed
the
inlined-position
branch
from
71eab15 to
d736ed2
Compare
Tetchki
force-pushed
the
inlined-position
branch
from
d736ed2 to
d8dce0f
Compare
Check if the copied inlined node's expansion exists, and if not set it to the original node's expansion
Tetchki
force-pushed
the
inlined-position
branch
from
d8dce0f to
f22f9db
Compare
nicolasstucki
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the copied inlined node's expansion exists, and if not set it to the original node's expansion.
This commit was exctracted from #17055. This simplifies the next step that refactors inlined nodes to keep them until the backend phase.