Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not beta-reduce/eta-expand pattern splices with contextual function types #18198

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Do not beta-reduce/eta-expand pattern splices with contextual function types #18198

merged 1 commit into from
Jul 23, 2023

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jul 13, 2023 •
edited
Loading

The change in typedUnnamed fixes beta-reduction on the type that eliminated the implicit argument. Then the second fix in adaptNoArgsOther ensures that we do not transform ${x} into (ev ?=> ${x}.apply(x)).

Fixes #18197

@nicolasstucki nicolasstucki changed the title Do not eta-expand pattern splices with contextual function types Do not beta-reduce/eta-expand pattern splices with contextual function types Jul 13, 2023
@nicolasstucki nicolasstucki self-assigned this Jul 13, 2023
@nicolasstucki nicolasstucki marked this pull request as ready for review July 13, 2023 15:24
@nicolasstucki nicolasstucki requested a review from odersky July 13, 2023 15:24
@odersky odersky merged commit a0121f3 into scala:main Jul 23, 2023
@odersky odersky deleted the fix-18197 branch July 23, 2023 17:35
@Kordyjan Kordyjan added this to the 3.4.0 milestone Aug 1, 2023
@Kordyjan Kordyjan mentioned this pull request Dec 1, 2023
Merged
Kordyjan added a commit that referenced this pull request Dec 8, 2023
@Kordyjan
Backport "Do not beta-reduce/eta-expand pattern splices with contextu…
7169347 
…al function types" to LTS (#19127)

Backports #18198 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan modified the milestones: 3.4.0, 3.3.2 Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.

Matching on an Expr that takes in a context function fails when the context param is used at call site
3 participants
@nicolasstucki @odersky @Kordyjan