Fix: Correct the navigation to anchor #17910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dedelweiss
force-pushed
the
17182-anchor-navigation-bug
branch
from
2ee3914 to
657ae6e
Compare
Dedelweiss
force-pushed
the
17182-anchor-navigation-bug
branch
from
657ae6e to
bb16919
Compare
|
Another solution would be to add a |
Dedelweiss
changed the title
Florian3k
reviewed
Jun 9, 2023
|
Thanks, that seems to be working fine. I left one suggestion. I was wondering whether we could do something to not remove this part or URL, if user wants to link to specific section, but let's leave that for future work. |
Thank you for your feedback @Florian3k, yes I was wondering too,indeed it can be useful. I can take a look at it for another PR. |
Florian3k
approved these changes
Jun 9, 2023
Kordyjan
pushed a commit
that referenced
this pull request
Nov 17, 2023
The browser compatibility of [`location.hash`](https://developer.mozilla.org/en-US/docs/Web/API/Location/hash) seems to be out of date. That's why in this fix, I suggest using [`history.replaceState`](https://developer.mozilla.org/en-US/docs/Web/API/History/replaceState). ## Before: https://github.com/lampepfl/dotty/assets/44496264/a1399b0b-e4e8-4754-b146-661b59a01824 ## After: https://github.com/lampepfl/dotty/assets/44496264/22f38852-0cc5-48eb-a6e7-699f11628401 Fixes: #17182 [Cherry-picked 7694985]
Kordyjan
added a commit
that referenced
this pull request
Nov 21, 2023
Backports #17910 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser compatibility of
location.hashseems to be out of date. That's why in this fix, I suggest usinghistory.replaceState.Before:
Screen.Recording.2023-06-06.at.10.12.13.mov
After:
Screen.Recording.2023-06-06.at.13.46.20.mov
Fixes: #17182