Don't generate a super accessor for an inline method call #17598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline methods cannot be overridden, so they don't need super accessors. Fixes scala#17584
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
There is another similar case that fails import language.experimental.erasedDefinitions
trait A:
erased def g = 1
trait B extends A:
erased def f = super.g
class C extends B |
| val needAccessor = name.isTermName && ( | ||
| val needAccessor = | ||
| name.isTermName // Types don't need super accessors | ||
| && !sym.isInlineMethod && ( // Inline methods can't be overridden, don't need superaccessors |
There was a problem hiding this comment.
Suggested change
| && !sym.isInlineMethod && ( // Inline methods can't be overridden, don't need superaccessors | |
| && !sym.isEffectivelyErased | |
| && !sym.isInlineMethod && ( // Inline methods can't be overridden, don't need superaccessors |
|
It would also be good to add this example where the inline method is retained trait T:
def g = 2
trait A extends T:
inline override def g = 1
trait B extends A:
def f = super.g
class C extends B
@main def Test =
val c = C()
assert(c.f == 1) |
nicolasstucki
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline methods cannot be overridden, so they don't need super accessors.
Fixes #17584