Fix superType of SuperType #17574
Merged
Fix superType of SuperType #17574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not quite sure abput he previous definition of superType in SuperType. I believe it's probably needed for something. But it's clearly wrong if the `supertpe` argument does not have a symbol. We now fall back to the default `superType = underlying` in this case. Fixes $17555
som-snytt
reviewed
May 24, 2023
tests/run/i17555.scala
Outdated
|
|
||
| @main def Test = | ||
| println(C()) | ||
| println(D()) |
There was a problem hiding this comment.
vulpix does not verify output without a check file, so assert is more effective or defensive.
There was a problem hiding this comment.
Oh, yes, that was an oversight. Thanks for pointing it out!
dwijnand
approved these changes
May 25, 2023
Kordyjan
added a commit
that referenced
this pull request
Nov 17, 2023
Backports #17574 to the LTS branch. PR submitted by the release tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not quite sure about he previous definition of superType in SuperType. I believe it's probably needed for something. But it's clearly wrong if the
supertpeargument does not have a symbol. We now fall back to the defaultin this case.
Fixes #17555