Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert that symbols created using reflect API have correct privateWithin symbols #17352

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Assert that symbols created using reflect API have correct privateWithin symbols #17352

merged 1 commit into from
Apr 28, 2023

Conversation

KacperFKorban
Copy link
Member

closes lampepfl#17351

@nicolasstucki nicolasstucki self-requested a review April 27, 2023 08:35
@nicolasstucki nicolasstucki self-assigned this Apr 27, 2023
nicolasstucki
nicolasstucki reviewed Apr 27, 2023
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala Outdated Show resolved Hide resolved
compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala Outdated Show resolved Hide resolved
compiler/src/scala/quoted/runtime/impl/QuotesImpl.scala Outdated Show resolved Hide resolved
tests/neg/i17351/macro.scala Outdated Show resolved Hide resolved
tests/neg/i17351/main.scala Outdated Show resolved Hide resolved
tests/neg/i17351/main.scala Outdated Show resolved Hide resolved
tests/neg/i17351/main.scala Outdated Show resolved Hide resolved
@KacperFKorban KacperFKorban marked this pull request as ready for review April 27, 2023 11:36
@nicolasstucki nicolasstucki merged commit 3e6a261 into scala:main Apr 28, 2023
@nicolasstucki nicolasstucki deleted the fix-i17351 branch April 28, 2023 06:48
@KacperFKorban KacperFKorban mentioned this pull request May 8, 2023
Merged
@KacperFKorban KacperFKorban mentioned this pull request May 31, 2023
Closed
@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

RefinedPrinter crashes on a symbol with a term symbol as privateWithin
3 participants
@KacperFKorban @nicolasstucki @Kordyjan