Include P in the implicit scope of P.this.type
#17088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, `one` compiled but `two` didn't in:
class Foo[+T]
class Elem:
def one(a: Elem, x: Foo[a.type]): Int = x.ext
def two(x: Foo[Elem.this.type]): Int = x.ext
object Elem:
extension (x: Foo[Elem]) def ext: Int = 1
This happened because the anchors of the singleton reference `a.type` includes
its underlying type `Elem`, but `Elem.this.type` has no anchors at all. This
commit changes the definition of anchors to rectify this, which also brings us
closer to how Scala 2 behaves.
odersky
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit,
onecompiled buttwodidn't in:This happened because the anchors of the singleton reference
a.typeincludes its underlying typeElem, butElem.this.typehas no anchors at all. This commit changes the definition of anchors to rectify this, which also brings us closer to how Scala 2 behaves.