Make unchecked cases non-@unchecked and non-unreachable
#16958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
force-pushed
the
unchecked-unreachable-enum-vals
branch
6 times, most recently
from
83093d0 to
99f6ab9
Compare
dwijnand
force-pushed
the
unchecked-unreachable-enum-vals
branch
6 times, most recently
from
31b0aec to
a1a8758
Compare
|
@liufengyun as usual, any comments or questions welcome - we always end up with a better change afterwards! 😉 |
dwijnand
force-pushed
the
unchecked-unreachable-enum-vals
branch
from
a1a8758 to
6b36cd9
Compare
dwijnand
added a commit
that referenced
this pull request
Aug 8, 2023
Reverts a key part of #16958, which is a complicated case, to fix the regression(s).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16451