Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Xcheck-macros: add hint when a symbol in created twice #16733

Merged
merged 1 commit into from
May 9, 2023
Merged

-Xcheck-macros: add hint when a symbol in created twice #16733

merged 1 commit into from
May 9, 2023

Conversation

nicolasstucki
Copy link
Contributor

Closes #16363

ckipp01
ckipp01 approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Macros aren't may forte, but this has been here for months, and this seems to make sense. I think this should be somewhat safe to merge.

@nicolasstucki nicolasstucki requested review from smarter and removed request for aherlihy May 9, 2023 18:50
@nicolasstucki nicolasstucki assigned smarter and unassigned aherlihy May 9, 2023
@smarter smarter merged commit 5a9b616 into scala:main May 9, 2023
@smarter smarter deleted the fix-16363 branch May 9, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhelpful "Tree had an unexpected owner" error message
4 participants
@nicolasstucki @smarter @ckipp01 @aherlihy