Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute completions at typerPhase #16371

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Compute completions at typerPhase #16371

merged 1 commit into from
Nov 18, 2022

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Nov 18, 2022

Fixes #16360

@odersky
Copy link
Contributor Author

odersky commented Nov 18, 2022

The fix addresses the obvious problem. I don't know why it worked before 3.2.1. It would be interesting to find out.

  • Was no implicit search performed then?
  • Or did the completion request from the REPL run at typerPhase? (now it is parserPhase

@odersky odersky requested a review from prolativ November 18, 2022 09:44
@odersky odersky merged commit 7813558 into scala:main Nov 18, 2022
@odersky odersky deleted the fix-16360 branch November 18, 2022 13:45
@mpollmeier mpollmeier mentioned this pull request Nov 23, 2022
Closed
@dwijnand
Copy link
Member

The fix addresses the obvious problem. I don't know why it worked before 3.2.1. It would be interesting to find out.

@odersky see #16551

@Kordyjan Kordyjan added this to the 3.2.2 backports milestone Dec 22, 2022
@Kordyjan Kordyjan added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Dec 22, 2022
@Kordyjan Kordyjan mentioned this pull request Dec 22, 2022
Closed
@Kordyjan Kordyjan added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" backport:done This PR was successfully backported. and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prolativ prolativ prolativ approved these changes

Assignees

@prolativ prolativ

Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.2.2 backports
Development

Successfully merging this pull request may close these issues.

REPL crashes on code completion for a subtype of Selectable
4 participants
@odersky @dwijnand @prolativ @Kordyjan