Make lazy vals run on non-fallback graal image - remove dynamic reflection #16346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
requested changes
Nov 17, 2022
| } | ||
| } | ||
| private[this] val unsafe: sun.misc.Unsafe = { | ||
| val unsafeField = classOf[sun.misc.Unsafe].getDeclaredField("theUnsafe").nn |
There was a problem hiding this comment.
This will throw a NoSuchFieldException if it is not there. Previously we got a more explicit "Can't find instance of sun.misc.Unsafe". We should preserve that behavior, IMO.
| else throw new ExceptionInInitializerError { | ||
| new IllegalStateException("Can't find instance of sun.misc.Unsafe") | ||
| } | ||
| unsafeField.get(null).asInstanceOf[sun.misc.Unsafe] |
There was a problem hiding this comment.
Any reason that the setAccessible is within the if/then/else, but get is after? Consider putting them both in the same code path.
sjrd
approved these changes
Nov 17, 2022
szymon-rd
force-pushed
the
fix/graalvm-lazy-vals
branch
from
3913572 to
57a04cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13985
I tested it and it seems to fix the issue