Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Kyma Provisioning Parameters to allow multiple OIDC definitions #423

Open
2 tasks
Tracked by #18305
kwiatekus opened this issue Feb 1, 2024 · 3 comments
Open
2 tasks
Tracked by #18305
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Comments

@kwiatekus
Copy link
Contributor

kwiatekus commented Feb 1, 2024

Description

Adjust set of input parameters of Kyma Service Instance Provisioning so that user can provide multiple OIDC configs (design oidc paramater so that in accepts a single config (for backwards compatibility) or an array).

Extend the OIDC schema so that user could also define requiedClaims (key-value pairs) that are essential for secure GH workflow access.

AC

  • User can define multiple OIDC configs
  • User can define required claims per OIDC config

Reasons

It is required to configure access to freshly created clusters via additional "workflow" OIDC
kyma-project/kyma#18305

Attachments

@kwiatekus kwiatekus changed the title Extend Kyma Provisioning Parameters with additional "worfklow" OIDC definition Extend Kyma Provisioning Parameters to allow multiple OIDC definitions May 24, 2024
@PK85
Copy link

PK85 commented Jun 12, 2024

Looks that Provisioner exposes APIs with pods and services CIDRs. We need to test it.

@kwiatekus
Copy link
Contributor Author

As a first step we could enable that only for DEV landscape on a dedicated plan (preview):

  • make sure KEB on DEV is creating RuntimeCR
  • make sure KEB can consume extended provisiong parameters (incl. required claims and multiple oidc)

@ralikio
Copy link
Member

ralikio commented Jul 3, 2024

Proposed based on last planning:

To preserve backward compatibility we would like to define a new parameter (e.g. "Additional OIDC") defined in the schema as a list. Old parameter will be functional and extended with requiredClaims. If user defined additional OIDC in the list and at the same time provides backward compatible one then we want to merge both.

@ralikio ralikio added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 3, 2024
@PK85 PK85 added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

No branches or pull requests

3 participants