-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typed parameter support #988
Comments
👍 to this. It's potentially a pretty big story. Not sure if we'll need to use reflect here. I'm tempted to wait on this until we can make typed CRDs for each operator, because then we can generate and take advantage of CRD OpenAPIv3 specs. |
Should we work on a KEP for this? |
I just noticed that there's a "needs KEP" label... 🙂 |
There is a need for KEP... and perhaps we should look at params / values as a whole (in that KEP). |
Support for
What about maps? |
What would you like to be added:
Support for
boolean
,array
,integer
,float
params.yaml
parameters.Bonus points for
object
type support.Why is this needed:
Configuration files for KUDO operators (potentially YAML templates) usually
require array or object settings. Being able to more easily template in arrays
and objects, and to use booleans directly as template predicates instead of
using text equality to "true" or "false" strings would be nice.
Adding typed setting support also sets the stage for parameter validation. For
example,
integer
values might validate bounds checking in the form ofmininum
andmaximum
fields.Or
enum
validation for optionalstring
types:The text was updated successfully, but these errors were encountered: