-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sudo for elevated permissions while upgrading clusters using kubeadm #44832
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think its worth to mention sudo. Preview page: |
75e4eec
to
c6e210f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these all the commands that need sudo on the pages?
/lgtm
but leaving to SIG docs what needs to be done here.
we had a discussion before that the sudo requirement can be just a note on top of the doc instead of having sudo on every command.
LGTM label has been added. Git tree hash: b9a5565de5441af669e9fc62f1b04b05918d16af
|
/sig cluster-lifecycle |
I have executed the steps on this page several times. I am pretty confident that all commands that need sudo have been taken care of in this PR. |
Good suggestion, |
I believe most readers would copy paste the commands. And it is an inconvenience to re-execute with sudo each time a command fails with permissions. Some commands on the page already had the sudo prefixed. This PR adds it to the missing ones. |
@@ -43,7 +43,7 @@ The upgrade workflow at high level is the following: | |||
they could be running CoreDNS Pods or other critical workloads. For more information see | |||
[Draining nodes](/docs/tasks/administer-cluster/safely-drain-node/). | |||
- The Kubernetes project recommends that you match your kubelet and kubeadm versions. | |||
You can instead use an a version of kubelet that is older than kubeadm, provided it is within the | |||
You can instead use a version of kubelet that is older than kubeadm, provided it is within the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit)
I'd have put this fixup in a separate commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider mentioning sudo
in the prerequisites, and ideally tell people that alternative tools work fine.
(I like using PolicyKit locally, and sometimes use alternatives to sudo
on servers).
Anyway:
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The pages for Upgrading kubeadm clusters and Upgrading Linux nodes have reference to
apt
,apt-cache
,apt-mark
,apt-get
,yum
andkubeadm upgrade apply
commands. These commands need elevated permissions throughsudo
(if executed without root).The PR adds the usage of
sudo
for these commands to ease the experience for the reader.Regards,
Aditya