Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello Minikube page has a broken link / anchor named "Open Dashboard with URL" #44236

Closed
adityasamant25 opened this issue Dec 6, 2023 · 10 comments · Fixed by #42025
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@adityasamant25
Copy link
Contributor

This is a Bug Report

Problem:
The Hello Minikube page has a broken link / anchor named "Open Dashboard with URL" in the Dashboard section.
The markdown anchor named #open-dashboard-with-url cannot be resolved.

Proposed Solution:
This link / anchor needs to be fixed, however I am not able to understand what section it referred to in the first place.

Page to Update:
https://kubernetes.io/docs/tutorials/hello-minikube/

@adityasamant25 adityasamant25 added the kind/bug Categorizes issue or PR as related to a bug. label Dec 6, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 6, 2023
@thisisharrsh
Copy link
Contributor

/language en
/sig docs

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 6, 2023
@thisisharrsh
Copy link
Contributor

@thisisharrsh
Copy link
Contributor

I think the URL should be replaced with https://minikube.sigs.k8s.io/docs/handbook/dashboard/#getting-just-the-dashboard-url

@thisisharrsh
Copy link
Contributor

Let's wait for the opinions of other members regarding the same.

@thisisharrsh
Copy link
Contributor

I would to like to work on this issue is the triage gets accepted.

@adityasamant25
Copy link
Contributor Author

@thisisharrsh Thanks.

I checked further. Please check v1.24 of Hello Minikube. Here you will find the section for the "Open Dashboard with URL".
It seems this section was removed in later versions of this page, but the anchor/link was not removed.

@dipesh-rawat
Copy link
Member

The anchor for "Open Dashboard with URL," previously in use, is now obsolete as we've integrated this content into tab layout (Launch a browser, URL copy and paste) on the current page.

@dipesh-rawat
Copy link
Member

Pull request #42025 has been submitted quite some time ago to handle this issue, and it's awaiting review and approval for merging.

@adityasamant25
Copy link
Contributor Author

@dipesh-rawat Indeed. Once #42025 is approved, it will address this issue.
I do not see anyone actively working on this PR since many days.
@thisisharrsh has volunteered to help. @thisisharrsh please take a look at #42025
There are some suggestions from @sftim in the PR already.

@divya-mohan0209
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants