Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why klog? #43

Closed
filmil opened this issue Feb 11, 2019 · 4 comments · Fixed by #48
Closed

Why klog? #43

filmil opened this issue Feb 11, 2019 · 4 comments · Fixed by #48
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@filmil
Copy link

filmil commented Feb 11, 2019

/kind bug

It would be nice for the README file for klog to explain why the fork, versus contributing to glog.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 11, 2019
@aledbf
Copy link
Member

aledbf commented Feb 11, 2019

@filmil maybe because the glog README contains
The code in this repo is for export only and is not itself under development. Feature requests will be ignored.

@filmil
Copy link
Author

filmil commented Feb 11, 2019

That explains just what it is, not why it is. :)

I would expect a sentence like: "We forked glog because..."

@jaredallard
Copy link

jaredallard commented Feb 13, 2019

I'm going to try to get this done by EOD Friday, if anyone else plans on working on this please @ me so that we don't duplicate efforts!

(Will insert PR below when finalized)

EDIT Still working on this, but I've gotten super sick over the last two days... hoping to have it by Tuesday now (if all goes well!) 😷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants