genericclioptions: Inferring namespace from config flag or kubeconfig

[ahmetb]

I'm trying to implement a very simple "kubectl get" using pkg/genericclioptions.

In my command, I see --namespace option registered.
When I invoke my command, I don't specify any value for --namespace, because I expect that it will read the kubeconfig (using default loading rules) and find the current namespace name (if set), otherwise will assume "default".

However, when I create a client and query, I get no namespace segment in URLs, so my Get() requests are failing with 404.

How is someone supposed to automatically have namespace field populated while using genericclioptions?

Here's what I'm doing:

    cf = genericclioptions.NewConfigFlags(true)
    cf.AddFlags(rootCmd.Flags()) 

    restConfig, err := cf.ToRESTConfig()
	if err != nil {
		return err
	}

    dyn, err := dynamic.NewForConfig(config)
	if err != nil {
		return nil, fmt.Errorf("failed to construct dynamic client: %w", err)
	}

    result, err := dyn.Resource(apiRes).Get(name, metav1.GetOptions{})
	if err != nil {
		return fmt.Errorf("failed to get: %w", err)
	}
    // debugging shows Get() call above doesn't add a "namespace" segment to the URL

I have tried doing dyn.Resource(apiRes).Namespace(*cf.Namespace).Get(...) but since --namespace is not specified it won't do anything.

Since I use ToRESTConfig() method, I expect this package to automatically find my namespace (from kubeconfig) or assume "default" and inject that to the URL.

Why is this not happening?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[ahmetb]

/lifecycle frozen

[vharsh]

Ah, this is likely happening because the methods like ToDiscoveryClient, ToRESTConfig() expect AddFlags method to have been called earlier(preferably with all the args passed to the binary) but this hasn't happened already in pkg/genericclioptions with the right set of pflags from taken from the os.Args.

IMO, shouldn't cf.AddFlags be called with all arguments(os.Args) as rootCmd might not have defined all the --token, --namespace, --password flags.