Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the readability for multiple errors in kusttarget #3192

Merged
merged 4 commits into from
Nov 7, 2020
Merged

Improve the readability for multiple errors in kusttarget #3192

merged 4 commits into from
Nov 7, 2020

Conversation

Shell32-Natsu
Copy link
Contributor

close #2279

  • Use github.com/hashicorp/go-multierror module to improve the readability when accumulateResource returns multiple errors.

Before:

Error: accumulating resources: accumulateFile "accumulating resources from 'https://github.com/kustless/kustomize-examples/archive/master.zip//kusto
mize-example-master': YAML file [https://github.com/kustless/kustomize-examples/archive/master.zip//kustomize-example-master] encounters a format er
ror.\nerror converting YAML to JSON: yaml: line 165: mapping values are not allowed in this context\n", loader.New "evalsymlink failure on '/tmp/kus
tomize-935615573/archive/master.zip/kustomize-example-master' : lstat /tmp/kustomize-935615573/archive: no such file or directory"

After:

Error: accumulating resources: 2 errors occurred:
        * accumulateFile error: "accumulating resources from 'https://github.com/kustless/kustomize-examples/archive/master.zip//kustomize-example-m
aster': YAML file [https://github.com/kustless/kustomize-examples/archive/master.zip//kustomize-example-master] encounters a format error.\nerror co
nverting YAML to JSON: yaml: line 165: mapping values are not allowed in this context\n"
        * loader.New error: "evalsymlink failure on '/tmp/kustomize-704954760/archive/master.zip/kustomize-example-master' : lstat /tmp/kustomize-70
4954760/archive: no such file or directory"
  • Some format updates in recent committed files.
  • go.sum files are updated and it makes non-sense to split them to different commits. So disable multi-module check.

ALLOW_MODULE_SPAN

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 6, 2020
monopole
monopole approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: monopole, Shell32-Natsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Shell32-Natsu,monopole]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0acac39 into kubernetes-sigs:master Nov 7, 2020
@Shell32-Natsu Shell32-Natsu deleted the multierror branch November 7, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monopole monopole monopole approved these changes

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@monopole monopole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Key error messages are not available in some condition
3 participants
@Shell32-Natsu @k8s-ci-robot @monopole