Daemonset Antiaffinity for Fargate Nodes

[ghost]

Is this a bug fix or adding new feature?

Bug fix. Relating to Issue 328

What is this PR about? / Why do we need it?

By default when following the docs at [1] with a mixed ec2/fargate EKS cluster the efs-csi-node DaemonSet will try to schedule to fargate nodes which results in pods becoming stuck in the "Pending" status.

This is easily resolvable with a node anti affinity rule.

[1] https://docs.aws.amazon.com/eks/latest/userguide/efs-csi.html

What testing is done?

I have tested the changes on my branch within a test cluster using the command below which is the exact command from the documentation but with a modified endpoint pointing to my test branch.

kubectl apply -k https://github.com/benmccown-amz/aws-efs-csi-driver/deploy/kubernetes/overlays/stable/ecr?ref=daemonset-antiaffinity-fargate

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @benmccown-amz!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @benmccown-amz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ghost]

Just got CLA sorted.

[wongma7]

/approve

thank you, could you squash the commits into 1. e.g. git rebase -i upstream/master ``

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmccown-amz, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wongma7]

/ok-to-test

[ghost]

@wongma7 commits have been squashed.

[wongma7]

/lgtm

thanks again

[wongma7]

/test pull-aws-efs-csi-driver-e2e

[wongma7]

/test pull-aws-efs-csi-driver-e2e

[nicogl]

@wongma7 @ben-mccown
The DaemonSet antiaffinity for Fargate nodes introduced here doesn't solve the issue. I tested it and still get PodNotSupported errors. I think the problem is that the way the "matchExpressions" element is defined doesn't have an infuence on the NodeGroup nodes:

    - matchExpressions:
        - key: eks.amazonaws.com/compute-type
          operator: NotIn
          values:
          - fargate

As per my understanding, above condition requires that the label "eks.amazonaws.com/compute-type" exists on the node for it to be evaluated. Now note that this label is only present on Fargate nodes, not on EC2 nodes beloging to a node group. This can be checked by running this command: kubectl get nodes --show-labels

The way I fixed it was changing the affinity to:

      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
            - matchExpressions:
              - key: eks.amazonaws.com/nodegroup
                operator: Exists
                values: []

This way I ensure that the related pods are run on a node group and not Fargate.

Last but not least, this affinity also has to be added to the "efs-csi-controller" Deployment element. Otherwise, the controller pods also throw errors.

Hope this makes sense, kind regards.