Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to use aws-sdk-go-v2 #1458

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Migrate to use aws-sdk-go-v2 #1458

merged 1 commit into from
Oct 7, 2024

Conversation

avanish23
Copy link
Contributor

@avanish23 avanish23 commented Sep 22, 2024 •
edited
Loading

Is this a bug fix or adding new feature?
This PR migrates to aws-sdk-go-v2
Context: https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/
Migration guide: https://aws.github.io/aws-sdk-go-v2/docs/migrating/

Basically maintenance mode on July 31, 2024 and reach end-of-support on July 31, 2025. The SDK will not
receive API updates for new or existing services, or be updated to support new regions.

Side note: Most of the changes are present in the /vendors directory as the aws-sdk-go-v2 files have gotten added, which don't need a really need a review, so the review process can be limited to 10 files

Closes #1421

What is this PR about? / Why do we need it?

What testing is done?
make test has passed succesfully

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 22, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: avanish23 / name: Avanish V Patil (79e098c)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 22, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 22, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @avanish23. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 22, 2024
@mskanth972
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2024
@mskanth972
Copy link
Contributor

Will review it by tomorrow

@avanish23
Copy link
Contributor Author

/retest

@avanish23 avanish23 force-pushed the aws-sdk-go-v2-migration branch from 0d48ceb to cc32fa8 Compare October 3, 2024 07:14
@mskanth972
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2024
@mskanth972
Copy link
Contributor

@avanish23, can you try to get the easycla issue resolved, so that I can approve?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2024
@avanish23 avanish23 force-pushed the aws-sdk-go-v2-migration branch from 94c8859 to 67d4421 Compare October 3, 2024 17:21
@avanish23
migrate to aws-sdk-go-v2
79e098c 
final migrate to aws-sdk-go-v2

generated mocks with the right commands

use LoadDefaultConfig for configs

easycla commit

easycla commit
@avanish23 avanish23 force-pushed the aws-sdk-go-v2-migration branch from 1f7d420 to 79e098c Compare October 3, 2024 17:28
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 3, 2024
@mskanth972
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avanish23, mskanth972

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 65cd90d into kubernetes-sigs:master Oct 7, 2024
6 checks passed
@jrakas-dev jrakas-dev mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashley-wenyizha Ashley-wenyizha Awaiting requested review from Ashley-wenyizha

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

Assignees

@mskanth972 mskanth972

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch to aws-sdk-go-v2 as v1 is going away
3 participants
@avanish23 @k8s-ci-robot @mskanth972