Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-daemonset.yaml lacks additionLabels #1388

Closed
guanchzhou opened this issue Jun 25, 2024 · 1 comment · Fixed by #1394
Closed

node-daemonset.yaml lacks additionLabels #1388

guanchzhou opened this issue Jun 25, 2024 · 1 comment · Fixed by #1394
Assignees

Comments

@guanchzhou
Copy link

guanchzhou commented Jun 25, 2024

Is your feature request related to a problem?/Why is this needed
We have Kyverno policy in place and it checks both .metadata.labels and .spec.template.metadata.labels.

Current charts/aws-efs-csi-driver/templates/node-daemonset.yaml lacks additionalLabels: {} while charts/aws-efs-csi-driver/templates/controller-deployment.yaml has it at

{{- with .Values.controller.additionalLabels }}

/feature

Describe the solution you'd like in detail
Add additionalLabels: {} to node-daemonset the same way as it added to controller-deployment.

@omerap12
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants