Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples for CoreV1Api.listNamespacedPod() is incorrect for version 20 and beyond of the client #3575

Open
bcarld opened this issue Jul 18, 2024 · 4 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@bcarld
Copy link

bcarld commented Jul 18, 2024

Describe the bug
Client version 20.0.1 and beyond changed the signature for all of the CoreV1Api.list* by removing all of the parameters that allow selectors, but the release notes to do provide guidance on how to filter the list.
After various web searches, I went to java doc and it does not provide any info (not too surprising since the javadoc is method specfic).
I then went to the examples and found and example. But, it is older as it has all of the old parameters.

For compatibility breaking changes, it would be nice to have better documentation in the release notes with the recommended new method to do what the previous method can no longer do due to the reduction of parameters.

Client Version
20.0.1

Kubernetes Version
e.g. 1.19.3

Java Version
e.g. Java 8

To Reproduce
Change 'io.kubernetes:client-java:19.0.1' to 'io.kubernetes:client-java:20.0.1' or later and try to build.

Expected behavior

  • release notes should reference documentation for recommendations on how to deal with a compatibility breaking change.
    -Code examples should either be for the latest code or reference the version to which the example applies.

Additional context
My problem is a build break due to moving up versions to resolve a security vulnerability in one of the packages used by the java client.

@bcarld
Copy link
Author

bcarld commented Jul 18, 2024

@brendandburns
Copy link
Contributor

Thanks for pointing that out, we should probably just delete those examples from the wiki, the up to date examples are here:

https://github.com/kubernetes-client/java/tree/master/examples/examples-release-20

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants