Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify custom resolver #546

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

specify custom resolver #546

wants to merge 3 commits into from

Conversation

ktr0731
Copy link
Owner

@ktr0731 ktr0731 commented May 14, 2022

Currently, messages will be decode/encoded with only protoregistry.GlobalTypes. However, it's possible to receive a message which is not registered in protoregistry.GlobalTypes (e.g. grpc-status-details-bin).
This PR makes the resolver specify "descriptor source" such as gRPC reflection or file descriptors.

@ktr0731 ktr0731 self-assigned this May 14, 2022
@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #546 (7917121) into master (823938c) will decrease coverage by 0.56%.
The diff coverage is 54.81%.

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
- Coverage   79.88%   79.31%   -0.57%     
==========================================
  Files          57       59       +2     
  Lines        3867     3974     +107     
==========================================
+ Hits         3089     3152      +63     
- Misses        546      583      +37     
- Partials      232      239       +7     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant